fix(typing): export SQLModelConfig and allow ConfigDict for model_config (#2091) - #2092
Open
DYNOSuprovo wants to merge 1 commit into
Open
Conversation
…fig (fastapi#2091) Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2091.
Problem
In
sqlmodel,SQLModelMetaclassdeclaredmodel_config: SQLModelConfig.SQLModelConfigwas only defined insqlmodel._compatand was not re-exported bysqlmodelorsqlmodel.main, preventing users from publicly importing or referencingSQLModelConfig.SQLModelConfiginherits from Pydantic'sBaseConfig/ConfigDict, assigning a standard PydanticConfigDictor a plain dictionary literal tomodel_configon anSQLModelsubclass triggered strict type errors in type checkers such as Astral'sty:Solution
SQLModelConfigand Pydantic'sConfigDictinsqlmodelandsqlmodel.main.SQLModelMetaclass.model_configannotation toSQLModelConfig | ConfigDict | dict[str, Any].tests/test_pydantic/test_model_config.pyverifyingSQLModelConfigandConfigDictpublic exports, type validity, and configuration behavior across models.Verification
pytest tests/test_pydantic/test_model_config.py: 6 passedty check sqlmodel: 0 diagnosticsty check tests/test_pydantic/test_model_config.py: 0 diagnosticsruff check sqlmodel tests: passedruff format sqlmodel tests --check: 171 files left unchanged